Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve LD_LIBRARY_PATH in start.sh #1981

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Preserve LD_LIBRARY_PATH in start.sh #1981

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04ccf68
Preserve LD_LIBRARY_PATH in start.sh
mathbunnyru Aug 24, 2023
83f67fc
Merge branch 'main' into asalikhov/preserve_ld_lib_path
mathbunnyru Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion images/docker-stacks-foundation/start.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ if [ "$(id -u)" == 0 ] ; then
unset_explicit_env_vars
_log "Running as ${NB_USER}:" "${cmd[@]}"
exec sudo --preserve-env --set-home --user "${NB_USER}" \
LD_LIBRARY_PATH="${LD_LIBRARY_PATH}" \
PATH="${PATH}" \
PYTHONPATH="${PYTHONPATH:-}" \
"${cmd[@]}"
Expand All @@ -165,7 +166,7 @@ if [ "$(id -u)" == 0 ] ; then
# used `env_delete` from /etc/sudoers. It has higher priority than the
# `--preserve-env` flag and the `env_keep` configuration.
#
# - We preserve PATH and PYTHONPATH explicitly. Note however that sudo
# - We preserve LD_LIBRARY_PATH, PATH and PYTHONPATH explicitly. Note however that sudo
# resolves `${cmd[@]}` using the "secure_path" variable we modified
# above in /etc/sudoers.d/path. Thus PATH is irrelevant to how the above
# sudo command resolves the path of `${cmd[@]}`. The PATH will be relevant
Expand Down