Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve LD_LIBRARY_PATH in start.sh #1981

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

mathbunnyru
Copy link
Member

Describe your changes

Issue ticket if applicable

Checklist (especially for first-time contributors)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • I will try not to use force-push to make the review process easier for reviewers
  • I have updated the documentation for significant changes

@mathbunnyru
Copy link
Member Author

I created this Dockerfile and built it with docker build -t test .:

FROM jupyter/docker-stacks-foundation

ENV LD_LIBRARY_PATH=/test/

Then I ran: docker run -it --rm -e NB_USER=some-user --user root test start.sh
LD_LIBRARY_PATH was lost.
I think it's a good idea to keep it - people might install software, that might need LD_LIBRARY_PATH changes.
If they change NB_USER, then their image will stop working properly.

This PR fixes this issue.

@mathbunnyru
Copy link
Member Author

Credits to @benz0li in this PR: #1979

@benz0li
Copy link
Contributor

benz0li commented Aug 25, 2023

Cross reference: iot-salzburg/gpu-jupyter#108 (comment) ff

@mathbunnyru mathbunnyru merged commit cc47dbd into jupyter:main Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants