Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all swagger.json endpoints to support auth token header/query param #236

Closed
wants to merge 1 commit into from

Conversation

skbergam
Copy link

@skbergam skbergam commented Apr 3, 2017

No description provided.

@rolweber
Copy link
Contributor

rolweber commented Apr 4, 2017

I thought Swagger allows to define global security constraints, so that you don't have to add the same setting to each endpoint? See also issue #232, and this commit from the other pending PR: fcf1316

@skbergam
Copy link
Author

skbergam commented Apr 4, 2017

@rolweber: maybe you're right, but I had to add these changes to enable the auth token on the other endpoints. could be that removing it from the one endpoint is all that was necessary for Swagger to infer it was meant to be global?

/cc @parente

@rolweber
Copy link
Contributor

I merged the other PR that had swagger updates. Could you please check if that resolves your problem?
If not, please update this PR. I suggest to use a top-level security element. According to the spec, it is...

"A declaration of which security schemes are applied for the API as a whole."

@parente parente mentioned this pull request Apr 18, 2017
5 tasks
@parente
Copy link
Contributor

parente commented May 7, 2017

I added the security requirements section in #244. I think we can close this PR. Thanks @skbergam.

@parente parente closed this May 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants