Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swagger: auth token #232

Closed
rolweber opened this issue Mar 8, 2017 · 1 comment
Closed

Swagger: auth token #232

rolweber opened this issue Mar 8, 2017 · 1 comment
Milestone

Comments

@rolweber
Copy link
Contributor

rolweber commented Mar 8, 2017

According to swagger.yaml, only /api/kernelspecs requires the auth token.
https://github.com/rolweber/kernel_gateway/blob/e897143cb8ff84a9f52819005524f168675966cb/kernel_gateway/jupyter_websocket/swagger.yaml#L72

I thought it is required for all calls, if configured? Should swagger list the token as a top-level security element? If there are only few calls which do not require the token, it would still be easier to exempt those than to add the token to many calls individually.

@parente
Copy link
Contributor

parente commented Mar 8, 2017

That was a copy/paste mistake, and PR #227 fixes it. It might be worth calling out in the top level security section how auth is handled globally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants