Minimal Updates for JuMP v0.20 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me 👍 I wonder whether the tests fail when somebody uses an older version of Ipopt or Ipopt.jl, but that shouldn't matter for CI-reasons. |
|
@odow, any objections to merging and tagging this? I am wondering if we need to add some more tests to exercise these changes before tagging? jump-dev/MathOptInterface.jl#736 |
|
No objections. The changes to MOI should be hit by the tests in MOI.Test. MINLPTests should really just catch problems with the NLP stuff, which didn't change. |
|
Sounds good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@odow, @rschwarz, proposed minimal updates to get this package working with JuMP v0.20 so MINLP solvers can be updated accordingly.
@rschwarz, addresses the Ipopt fix you mentioned.