Skip to content

Commit

Permalink
Modified deprecated projectID field of Gitlab Eventsource to be optio…
Browse files Browse the repository at this point in the history
…nal (argoproj#1500)

* modified deprecated projectID field of gitlab eventsource to be optional

Signed-off-by: Daniel Soifer <[email protected]>

* modified deprecated projectID field of gitlab eventsource to be optional

Signed-off-by: Daniel Soifer <[email protected]>

* fix: Modified deprecated projectID field of gitlab eventsource to be optional

Signed-off-by: Daniel Soifer <[email protected]>

* codegen

Signed-off-by: Daniel Soifer <[email protected]>
  • Loading branch information
daniel-codefresh authored Jan 5, 2022
1 parent 2d8f379 commit 61220c9
Show file tree
Hide file tree
Showing 7 changed files with 6 additions and 5 deletions.
1 change: 1 addition & 0 deletions api/event-source.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions api/event-source.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion api/jsonschema/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -1499,7 +1499,6 @@
}
},
"required": [
"projectID",
"events",
"gitlabBaseURL"
],
Expand Down
1 change: 0 additions & 1 deletion api/openapi-spec/swagger.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pkg/apis/eventsource/v1alpha1/generated.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions pkg/apis/eventsource/v1alpha1/openapi_generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion pkg/apis/eventsource/v1alpha1/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -763,7 +763,8 @@ type GitlabEventSource struct {
Webhook *WebhookContext `json:"webhook,omitempty" protobuf:"bytes,1,opt,name=webhook"`
// DeprecatedProjectID is the id of project for which integration needs to setup
// Deprecated: use Projects instead. Will be unsupported in v 1.7
DeprecatedProjectID string `json:"projectID" protobuf:"bytes,2,opt,name=projectID"`
// +optional
DeprecatedProjectID string `json:"projectID,omitempty" protobuf:"bytes,2,opt,name=projectID"`
// Events are gitlab event to listen to.
// Refer https://github.com/xanzy/go-gitlab/blob/bf34eca5d13a9f4c3f501d8a97b8ac226d55e4d9/projects.go#L794.
Events []string `json:"events" protobuf:"bytes,3,opt,name=events"`
Expand Down

0 comments on commit 61220c9

Please sign in to comment.