Modified deprecated projectID field of Gitlab Eventsource to be optional #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Soifer <[email protected]>
Signed-off-by: Daniel Soifer <[email protected]>
…optional Signed-off-by: Daniel Soifer <[email protected]>
Signed-off-by: Daniel Soifer <[email protected]>
whynowy
approved these changes
Jan 5, 2022
BulkBeing
pushed a commit
to BulkBeing/argo-events
that referenced
this pull request
Mar 7, 2022
…nal (argoproj#1500) * modified deprecated projectID field of gitlab eventsource to be optional Signed-off-by: Daniel Soifer <[email protected]> * modified deprecated projectID field of gitlab eventsource to be optional Signed-off-by: Daniel Soifer <[email protected]> * fix: Modified deprecated projectID field of gitlab eventsource to be optional Signed-off-by: Daniel Soifer <[email protected]> * codegen Signed-off-by: Daniel Soifer <[email protected]>
juliev0
pushed a commit
to juliev0/argo-events
that referenced
this pull request
Mar 29, 2022
…nal (argoproj#1500) * modified deprecated projectID field of gitlab eventsource to be optional Signed-off-by: Daniel Soifer <[email protected]> * modified deprecated projectID field of gitlab eventsource to be optional Signed-off-by: Daniel Soifer <[email protected]> * fix: Modified deprecated projectID field of gitlab eventsource to be optional Signed-off-by: Daniel Soifer <[email protected]> * codegen Signed-off-by: Daniel Soifer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Soifer [email protected]
Fixes the following JSON schema validation error when using
projectsfield instead of the deprecatedprojectIDfield in a Gitlab Eventsource: