Add check 'duplicate-check-inputs'

overlays/duplicate-check-inputs.nix

@@ -0,0 +1,33 @@
+{ builtAttrs
+, packageSet
+, namePositions
+}@attrs:
+
+final: prev:
+let
+  inherit (prev) lib;
+  inherit (import ../lib { inherit lib; }) checkFor;
+
+  checkDerivation = drvArgs: drv:
+    let
+      list1 = drvArgs.propagatedBuildInputs or [];
+      list2 = drvArgs.checkInputs or [];
+      intersection = lib.intersectLists list1 list2;
+    in
+      lib.singleton {
+        name = "duplicate-check-inputs";
+        cond = builtins.length intersection > 0;
+        msg = ''
+          Dependencies listed in propagatedBuildInputs shouldn't be repeated in checkInputs.
+
+          Detected duplicates:
+
+            ${lib.concatStringsSep ",\n  " (map (d: d.name) intersection)}
+          '';
+        locations = [
+          (builtins.unsafeGetAttrPos "checkInputs" drvArgs)
+          (builtins.unsafeGetAttrPos "propagatedBuildInputs" drvArgs)
+        ];
+      };
+  in
+checkFor checkDerivation attrs final prev

run-tests.py

@@ -80,6 +80,10 @@ def __iter__(self):
             ],
         )
 
+        yield make_test_rule(
+            'duplicate-check-inputs',
+        )
+
         yield make_test_rule(
             'explicit-phases',
             [

tests/default.nix

@@ -5,6 +5,7 @@
 {
   attribute-ordering = pkgs.callPackage ./attribute-ordering { };
   build-tools-in-build-inputs = pkgs.recurseIntoAttrs (pkgs.callPackage ./build-tools-in-build-inputs { });
+  duplicate-check-inputs = pkgs.python3.pkgs.callPackage ./duplicate-check-inputs { };
   explicit-phases = pkgs.callPackage ./explicit-phases { };
   fixup-phase = pkgs.callPackage ./fixup-phase { };
   meson-cmake = pkgs.callPackage ./meson-cmake { };

tests/duplicate-check-inputs/default.nix

@@ -0,0 +1,12 @@
+{ buildPythonPackage
+, numpy
+}:
+
+buildPythonPackage {
+  pname = "patch-phase";
+
+  src = ../fixtures/make;
+
+  propagatedBuildInputs = [ numpy ];
+  checkInputs = [ numpy ];
+}