[evcohen/eslint-plugin-jsx-a11y#399] Accommodate ExperimentalSpreadProperty in prop values #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessebeach
force-pushed
the
undefined-value-expression
branch
from
9568a16
to
ffa911c
Compare
ljharb
approved these changes
Mar 17, 2019
| @@ -9,7 +9,8 @@ import getValue from './index'; | |||
| export default function extractValueFromObjectExpression(value) { | |||
| return value.properties.reduce((obj, property) => { | |||
| const object = Object.assign({}, obj); | |||
| if (property.type === 'SpreadProperty') { | |||
| // Support types: SpreadProperty and ExperimentalSpreadProperty | |||
| if (/SpreadProperty/.test(property.type)) { | |||
There was a problem hiding this comment.
Suggested change
| if (/SpreadProperty/.test(property.type)) { | |
| if (/^(?:Experimental)?SpreadProperty$/.test(property.type)) { |
this seems a bit more robust
There was a problem hiding this comment.
@ljharb I like the way you regex.
…operty in prop values
jessebeach
force-pushed
the
undefined-value-expression
branch
from
ffa911c
to
cb82b33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pattern like this:
Will cause
ObjectExpressionto throw an error. This diff properly treatsExperimentalSpreadPropertyas aSpreadProperty.