[evcohen/eslint-plugin-jsx-a11y#399] Accommodate ExperimentalSpreadPr…

…operty in prop values
jsx-eslint · Mar 17, 2019 · ffa911c · ffa911c
1 parent a1e5007
commit ffa911c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/__tests__/src/getPropValue-test.js b/__tests__/src/getPropValue-test.js
@@ -777,6 +777,15 @@ describe('getPropValue', () => {
 
       assert.deepEqual(expected, actual);
     });
+
+    it('should evaluate to a correct representation of the object, ignore spread properties', () => {
+      const prop = extractProp('<div foo={{ pathname: manageRoute, state: {...data}}} />');
+
+      const expected = { pathname: 'manageRoute', state: {} };
+      const actual = getPropValue(prop);
+
+      assert.deepEqual(expected, actual);
+    });
   });
 
   describe('New expression', () => {

diff --git a/src/values/expressions/ObjectExpression.js b/src/values/expressions/ObjectExpression.js
@@ -9,7 +9,8 @@ import getValue from './index';
 export default function extractValueFromObjectExpression(value) {
   return value.properties.reduce((obj, property) => {
     const object = Object.assign({}, obj);
-    if (property.type === 'SpreadProperty') {
+    // Support types: SpreadProperty and ExperimentalSpreadProperty
+    if (/SpreadProperty/.test(property.type)) {
       if (property.argument.type === 'ObjectExpression') {
         return Object.assign(object, extractValueFromObjectExpression(property.argument));
       }