-
-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add failing test for autocomplete with dynamic type #721
Conversation
This will cause axe to throw an error like: > TypeError: Cannot read property 'replace' of null I believe that the problem might be related to getLiteralPropValue returning `null` instead of `undefined` for dynamic props.
I pushed up a fix, but this is really a workaround for what's likely a bug in axe caused by using default values and forgetting that that doesn't handle |
Happy to file a bug upstream, but I'm not sure I understand what you mean by this:
|
hmm, the stack trace points to https://github.com/dequelabs/axe-core/blob/8a4d9b0970ad909100856faf102f14fea4d6c268/lib/commons/text/sanitize.js - but that would fail on undefined too, so my assumption (which may be incorrect) is that they've got code like It's really hard to figure out where the error is, though, since they apparently bundle the library :-/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lencioni !
Let's get this patch in. @WilcoFiers, the underlying issue here is with aXe; @ljharb has some theories in the comments above.
This will cause axe to throw an error like:
I believe that the problem might be related to getLiteralPropValue
returning
null
instead ofundefined
for dynamic props.