Merge pull request #721 from jsx-eslint/dynamic-input-type-autocomplete

Add failing test for autocomplete with dynamic type
jsx-eslint · Jul 4, 2020 · 31721bd · 31721bd
2 parents 7a34e45 + 2c47f0a
commit 31721bd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/__tests__/src/rules/autocomplete-valid-test.js b/__tests__/src/rules/autocomplete-valid-test.js
@@ -54,6 +54,7 @@ ruleTester.run('autocomplete-valid', rule, {
     { code: '<input type="text" autocomplete="invalid name" />;', errors: invalidAutocomplete },
     { code: '<input type="text" autocomplete="home url" />;', errors: invalidAutocomplete },
     { code: '<Bar autocomplete="baz"></Bar>;', errors: invalidAutocomplete, options: [{ inputComponents: ['Bar'] }] },
+    { code: '<input type={isEmail ? "email" : "text"} autocomplete="none" />;', errors: invalidAutocomplete },
 
     // FAILED "autocomplete-appropriate"
     { code: '<input type="date" autocomplete="email" />;', errors: inappropriateAutocomplete },

diff --git a/src/rules/autocomplete-valid.js b/src/rules/autocomplete-valid.js
@@ -35,12 +35,13 @@ module.exports = {
         return;
       }
 
+      const type = getLiteralPropValue(getProp(node.attributes, 'type'));
       const { violations } = runVirtualRule('autocomplete-valid', {
         nodeName: 'input',
         attributes: {
           autocomplete,
           // Which autocomplete is valid depends on the input type
-          type: getLiteralPropValue(getProp(node.attributes, 'type')),
+          type: type === null ? undefined : type,
         },
       });