Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prototype rewrite error #660

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prototype rewrite error #660

wants to merge 1 commit into from

Conversation

joe223
Copy link

@joe223 joe223 commented Jan 8, 2024 •
edited
Loading

This PR is to fix prototype rewrite error while we import jsonurl-js multiple times.

set configurable to true can avoid such errors.

@joe223 joe223 requested a review from dmaccormack as a code owner January 8, 2024 13:08
@AlonMiz
Copy link

AlonMiz commented Feb 24, 2024

will probably fix this issue #614

@joe223 joe223 mentioned this pull request Mar 6, 2024
Open
@AlonMiz AlonMiz mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmaccormack dmaccormack Awaiting requested review from dmaccormack dmaccormack is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joe223 @AlonMiz