Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix bug stringifying number-like keys and values #645

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

dmaccormack
Copy link
Collaborator

A string like "1e 6" will currently be stringified as 1e+6, which is ambiguous because it looks like a number literal and it will be parsed as one. This patch fixes the stringify code so that these strings are quoted. AQF strings have a similar issue and this patch addresses them as well.

A string like "1e 6" will currently be stringified as 1e+6, which is
ambiguous because it looks like a number literal and it will be parsed
as one. This patch fixes the stringify code so that these strings are
quoted. AQF strings have a similar issue and this patch addresses them
as well.
@dmaccormack dmaccormack added the bug Something isn't working label Nov 22, 2023
@dmaccormack dmaccormack self-assigned this Nov 22, 2023
@dmaccormack dmaccormack added this to the v1.1.8 milestone Nov 22, 2023
Copy link

sonarcloud bot commented Nov 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@dmaccormack dmaccormack merged commit 9f66986 into main Nov 22, 2023
27 checks passed
@dmaccormack dmaccormack deleted the fix-numberlike-kv-with-plus branch November 22, 2023 22:14
@macobo macobo mentioned this pull request May 31, 2024
@AlonMiz
Copy link

AlonMiz commented Jul 2, 2024

i think this version broke my code
im using the noproto version (for ssr with next js)
@dmaccormack

image image

all related to this
#614
#660

@dmaccormack
Copy link
Collaborator Author

Hi, @AlonMiz

There were no changes to function prototypes between v1.1.7 and v1.1.8. Your tooling might not pick up the typescript defs if you're importing the "noproto" version. It's not related to this commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants