-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"endDate": null should be equivalent to not having endDate #60
Comments
+1 for this. Can't put an endDate for currently working organization! |
Same here, it doesn't make sense to put an end date on your current job. |
+1 The team seems to agree with this per discussion on json-schema, but the cli version seems to not allow empty end date at this time. |
For those who don't know, the workaround for now is to remove endDate entirely from your json. |
Thank you :] But this needs to be implemented. |
Could there also be an alternative like |
Still this error is coming to me. FED UP with this error...... ex: {"endDate":"2011-11"} running validation tests on resume.json ... Cannot export. There are errors in your resume.json schema format.
fail 1 Please fix your resume.json file and try again ????????????????????????????? |
Is anybody else getting the same error as @Manju244? I will be adding support such that endDate can be null or left out. |
I wanted to display like this, Check out this: erming/resume-editor#13 "May 2014" - "Present" I am not able to do like this b'z of strong validation. |
@Manju244 what happens when you delete endDate? and are you using the cli publish tool? |
When i delete it it won't give any error, But i don't want to delete the ednDate and startDate???? I wanted to mention the startDate and endDate. |
So most of the templates, will detect if you don't have the endDate property and render "Present/Current" |
If blank giving error and if i delete that field then it's not rendering "Present/ Current" in my template...!!!! |
Which template is that? |
Default template "Flat"... Ref: http://registry.jsonresume.org/ |
@erming Do you have support for leaving out endDate? |
@thomasdavis Is their any template where it supports startDate and endDate like below, "May 2014" - "Present" |
Try |
NOOOOO......... Same error it's showing!!!! |
Really it's disappointing me to do something... Waited and Trying from last 3 weeks but no results i have.?????? |
maybe try then remove and try
|
I have tried everything and now also giving the same error..????? |
@Manju244 Are you using a date like If you can post your |
I guess, The thing is after validation only it will display in the theme. So it won't matter which template. But while creating JSON from default "Flat" template you are allowing to enter the dates as user gives input but when validate it's failing. It's misleading the user. Can you check and see the validation for this resume.json |
@Manju244 Yeah I don't think http://registry.jsonresume.org/ does any validation, it is just a GUI. In http://pastebin.com/cd6v6NHk try changing line 35 to: |
"startDate": "2014-05-01" will work in "Flat" template but display as 2014-05-01. But i wanted as "May 2014". |
@Manju244 That issue has to be dealt with by the theme. You can start an issue here if you would like to request it: https://github.com/erming/jsonresume-theme-flat/issues |
I tried using the --force option for publishing without an endDate set for my current postion, but this option seems to be ignored?
|
@schmkr There are 2 diff issues happening, one is that |
Please fix this. In addition, having to put only the year instead of the year, month, day would be beneficial |
Alright, I will push out all the fixes for dates today or tomorrow. On Fri, Nov 28, 2014 at 2:42 PM, Stuart Zahn [email protected]
Thomas Davis VP of Tech - Earbits - http://earbits.com |
@thomasdavis -- Any updates re: this issue? Oddly, my custom theme (http://demo.kamaldhari.com/jsonresume/) and all other themes seem to accept the regular text startDate and endDate values ONLY when pasting the JSON into the live front-end editor (i.e. "March 2011"). That's what you see here: http://demo.kamaldhari.com/jsonresume/ Stupid question, perhaps, but if I wanted to submit a pull request with my theme so that it appeared in the front-end editor, where would I do that? Carl V. Lewis |
Theme in action with responsive stylesheet: http://carlvlewis.net/jsonresume4/myCV.html And here's the JSON I'm using: http://carlvlewis.net/jsonresume4/json/resume.json Curious that it works that way but not on the cli version. |
@carlvlewis I don't think the web editor does any validation, it just tries to render it, whereas the CLI version validates the JSON first. |
Yeah, that explains the issue, but what's odd is that it validates properly elsewhere (i.e. JSONlint) but not in the CLI. Guess it just doesn't match the expected schema. Anyhow, solution was just to view and paste source, then manually remove the GUI frame from HTML, which works but kind of defeats the point of JSON in the first place (portability) http://carlvlewis.net/JSON-bootstrap-cv/ Needs a few more tweaks but will publish it in repo soon. Sent from my iPhone
|
@mchelen Are there any plans to do the validation inside the web editor ? Because I see issues being raised on themes because of that. See this mudassir0909/jsonresume-theme-elegant#23 |
So we will most likely create an official themes utility repository which theme developers can depend on to expose re-usable functions such as date conversion. |
@thomasdavis Actually I was planning for the same too :-) Let me know is there any specific plan or a roadmap. Or do you want me to start it & let's update it as we go forward ? By the way I do not want to hijack this thread for that discussion. |
@carlvlewis Why not store the date as "2011-03-01" and have your theme display it as "March 2011"? @mudassir0909 Agreed about validation in the web gui, created an issue for that here: jsonresume/registry-server#33 |
whats the actual input format want to give for these date fields ? |
after i remove the lines like "date" for all the above scenerios then also the same errors are triggering !!! |
Hey, @errakeshpd, the actual input is 'yyyy-mm-dd' according to most of the templates using the schema. So you'll need to change the values you have set for date to actual dates... |
Hi @carlvlewis , I also followed the same format, Like - 2015-05-01 => 'yyyy-mm-dd' |
@errakeshpd Can you post a snippet of the JSON you are using? |
@mchelen --force 👍 its worked !! |
@errakeshpd Great, glad that worked! |
Okay where are we at with this issue? Do we want this to work without having to use |
This is a schema issue, cf. jsonresume/resume-schema#199 |
This is still an issue. One should be able to show a single date without Present/Current following it. What about an event I volunteered for just one day in only one year or a class that was only 1 month long? "2015 - 2015" Looks stupid. "2015 - Present" isn't accurate. I've read all the related threads and haven't found a solution for this. Anyone else interested in this? |
No description provided.
The text was updated successfully, but these errors were encountered: