Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"endDate": null should be equivalent to not having endDate #60

Closed
dbkaplun opened this issue Sep 15, 2014 · 50 comments
Closed

"endDate": null should be equivalent to not having endDate #60

dbkaplun opened this issue Sep 15, 2014 · 50 comments

Comments

@dbkaplun
Copy link
Member

No description provided.

@shadowfax92
Copy link

+1 for this. Can't put an endDate for currently working organization!

@moleike
Copy link

moleike commented Sep 27, 2014

Same here, it doesn't make sense to put an end date on your current job.

@lannybroo
Copy link

+1 The team seems to agree with this per discussion on json-schema, but the cli version seems to not allow empty end date at this time.

@lannybroo
Copy link

For those who don't know, the workaround for now is to remove endDate entirely from your json.

@Shahor
Copy link

Shahor commented Nov 7, 2014

Thank you :]

But this needs to be implemented.

@PragTob
Copy link

PragTob commented Nov 12, 2014

Could there also be an alternative like current ?

@Manju244
Copy link

Still this error is coming to me. FED UP with this error...... ex: {"endDate":"2011-11"}

running validation tests on resume.json ...

Cannot export. There are errors in your resume.json schema format.
Try using The JSONLInt Validator at: http://jsonlint.com/

 ✗ work[0].endDate is  expected 

fail 1

Please fix your resume.json file and try again
You can easily pinpoint problems that may occur in a JSON file at: http://jsonlint.com/

?????????????????????????????

@thomasdavis
Copy link
Member

Is anybody else getting the same error as @Manju244?

I will be adding support such that endDate can be null or left out.

@Manju244
Copy link

I wanted to display like this,

Check out this: erming/resume-editor#13

"May 2014" - "Present"
"May 2014" - "July 2014"

I am not able to do like this b'z of strong validation.

@thomasdavis
Copy link
Member

@Manju244 what happens when you delete endDate? and are you using the cli publish tool?

@Manju244
Copy link

When i delete it it won't give any error, But i don't want to delete the ednDate and startDate???? I wanted to mention the startDate and endDate.

@thomasdavis
Copy link
Member

So most of the templates, will detect if you don't have the endDate property and render "Present/Current"

@Manju244
Copy link

If blank giving error and if i delete that field then it's not rendering "Present/ Current" in my template...!!!!

@thomasdavis
Copy link
Member

Which template is that?

@Manju244
Copy link

Default template "Flat"... Ref: http://registry.jsonresume.org/

@thomasdavis
Copy link
Member

@erming Do you have support for leaving out endDate?

@Manju244
Copy link

@thomasdavis Is their any template where it supports startDate and endDate like below,

"May 2014" - "Present"
"May 2014" - "July 2014"

@thomasdavis
Copy link
Member

Try elegant

@Manju244
Copy link

NOOOOO......... Same error it's showing!!!!

@Manju244
Copy link

Really it's disappointing me to do something... Waited and Trying from last 3 weeks but no results i have.??????

@thomasdavis
Copy link
Member

maybe try npm install -g resume-cli to update your cli

then remove endDate from resume.json

and try

resume publish --theme elegant

@Manju244
Copy link

I have tried everything and now also giving the same error..?????

@mchelen
Copy link
Member

mchelen commented Nov 12, 2014

@Manju244 Are you using a date like 2011-11? If so, use 2011-11-01 and some themes will display it as 2011-11.

If you can post your resume.json somewhere that would help us see what is happening.

@Manju244
Copy link

I guess, The thing is after validation only it will display in the theme. So it won't matter which template. But while creating JSON from default "Flat" template you are allowing to enter the dates as user gives input but when validate it's failing. It's misleading the user.

Can you check and see the validation for this resume.json
http://pastebin.com/cd6v6NHk

@mchelen
Copy link
Member

mchelen commented Nov 12, 2014

@Manju244 Yeah I don't think http://registry.jsonresume.org/ does any validation, it is just a GUI. In http://pastebin.com/cd6v6NHk try changing line 35 to:
"startDate": "2014-05-01",
and remove line 36.

@Manju244
Copy link

"startDate": "2014-05-01" will work in "Flat" template but display as 2014-05-01. But i wanted as "May 2014".

@mchelen
Copy link
Member

mchelen commented Nov 12, 2014

@Manju244 That issue has to be dealt with by the theme. You can start an issue here if you would like to request it: https://github.com/erming/jsonresume-theme-flat/issues

@schmkr
Copy link

schmkr commented Nov 12, 2014

I tried using the --force option for publishing without an endDate set for my current postion, but this option seems to be ignored?

$  resume publish --force --theme modern

  running validation tests on resume.json ...

Cannot export. There are errors in your resume.json schema format.
Try using The JSONLInt Validator at: http://jsonlint.com/

     ✗ work[0].endDate is null expected string

  fail  1

@mchelen
Copy link
Member

mchelen commented Nov 13, 2014

@schmkr There are 2 diff issues happening, one is that work.endDate=""is not valid. This can be worked around by removing work.endDate line entirely, as mentioned by #60 (comment)
The other issue is that --force option is not in fact forcing export when using invalid resume.json. There is an issue for that #74 and a PR is linked if you want to try it & give feedback.

@mchelen mchelen added this to the Suggested Milestone milestone Nov 20, 2014
@szahn
Copy link

szahn commented Nov 28, 2014

Please fix this. In addition, having to put only the year instead of the year, month, day would be beneficial

@thomasdavis
Copy link
Member

Alright, I will push out all the fixes for dates today or tomorrow.

On Fri, Nov 28, 2014 at 2:42 PM, Stuart Zahn [email protected]
wrote:

Please fix this


Reply to this email directly or view it on GitHub
#60 (comment)
.

Thomas Davis
http://thomasdav.is

VP of Tech - Earbits - http://earbits.com
Co-founder - Cdnjs - http://cdnjs.com
Founder - Backbone Tutorials - http://backbonetutorials.com

@carlvlewis
Copy link

@thomasdavis --

Any updates re: this issue? Oddly, my custom theme (http://demo.kamaldhari.com/jsonresume/) and all other themes seem to accept the regular text startDate and endDate values ONLY when pasting the JSON into the live front-end editor (i.e. "March 2011"). That's what you see here: http://demo.kamaldhari.com/jsonresume/

Stupid question, perhaps, but if I wanted to submit a pull request with my theme so that it appeared in the front-end editor, where would I do that?

Carl V. Lewis
http://carlvlew.is
[email protected]

@carlvlewis
Copy link

Theme in action with responsive stylesheet: http://carlvlewis.net/jsonresume4/myCV.html

And here's the JSON I'm using: http://carlvlewis.net/jsonresume4/json/resume.json

Curious that it works that way but not on the cli version.

@mchelen
Copy link
Member

mchelen commented Dec 19, 2014

@carlvlewis I don't think the web editor does any validation, it just tries to render it, whereas the CLI version validates the JSON first.

@carlvlewis
Copy link

Yeah, that explains the issue, but what's odd is that it validates properly elsewhere (i.e. JSONlint) but not in the CLI. Guess it just doesn't match the expected schema.

Anyhow, solution was just to view and paste source, then manually remove the GUI frame from HTML, which works but kind of defeats the point of JSON in the first place (portability) http://carlvlewis.net/JSON-bootstrap-cv/

Needs a few more tweaks but will publish it in repo soon.

Sent from my iPhone

On Dec 19, 2014, at 11:10 AM, Mike Chelen [email protected] wrote:

@carlvlewis I don't think the web editor does any validation, it just tries to render it, whereas the CLI version validates the JSON first.


Reply to this email directly or view it on GitHub.

@mudassir0909
Copy link
Member

@mchelen Are there any plans to do the validation inside the web editor ? Because I see issues being raised on themes because of that. See this mudassir0909/jsonresume-theme-elegant#23

@thomasdavis
Copy link
Member

So we will most likely create an official themes utility repository which theme developers can depend on to expose re-usable functions such as date conversion.

@mudassir0909
Copy link
Member

@thomasdavis Actually I was planning for the same too :-)

Let me know is there any specific plan or a roadmap. Or do you want me to start it & let's update it as we go forward ? By the way I do not want to hijack this thread for that discussion.

@mchelen
Copy link
Member

mchelen commented Dec 21, 2014

@carlvlewis Why not store the date as "2011-03-01" and have your theme display it as "March 2011"?
JSONLint only checks for valid JSON, whereas the CLI validates against resume-schema.

@mudassir0909 Agreed about validation in the web gui, created an issue for that here: jsonresume/registry-server#33

@errakeshpd
Copy link

Same error when i used any of the themes available, i changed main.js - > var theme = "kendal"
if i used default theme also same error is occuring , Please find the attached image

date_error

@errakeshpd
Copy link

whats the actual input format want to give for these date fields ?

@errakeshpd
Copy link

after i remove the lines like "date" for all the above scenerios then also the same errors are triggering !!!

@carlvlewis
Copy link

Hey, @errakeshpd, the actual input is 'yyyy-mm-dd' according to most of the templates using the schema. So you'll need to change the values you have set for date to actual dates...

@errakeshpd
Copy link

Hi @carlvlewis , I also followed the same format, Like - 2015-05-01 => 'yyyy-mm-dd'
and I also want to mention that the default template provided by the system also trigger the same error (Richard Hendriks Profile).

@mchelen
Copy link
Member

mchelen commented Jan 25, 2015

@errakeshpd Can you post a snippet of the JSON you are using?
Also the flag to force export is -F or --force not -f

@errakeshpd
Copy link

@mchelen --force 👍 its worked !!

@mchelen
Copy link
Member

mchelen commented Jan 26, 2015

@errakeshpd Great, glad that worked!

@rolandnsharp
Copy link
Member

Okay where are we at with this issue? Do we want this to work without having to use force or is that a valid option? I'll do what I can to resolve this issue asap. Or can this now be closed off?

@chrisdotcode
Copy link
Member

This is a schema issue, cf. jsonresume/resume-schema#199

@HeidiHansen
Copy link

This is still an issue. One should be able to show a single date without Present/Current following it. What about an event I volunteered for just one day in only one year or a class that was only 1 month long? "2015 - 2015" Looks stupid. "2015 - Present" isn't accurate. I've read all the related threads and haven't found a solution for this. Anyone else interested in this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests