Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --force/-F work for exports #74

Closed
PragTob opened this issue Nov 12, 2014 · 2 comments
Closed

Make --force/-F work for exports #74

PragTob opened this issue Nov 12, 2014 · 2 comments

Comments

@PragTob
Copy link

PragTob commented Nov 12, 2014

The --force/-F options do not work for local exports, from the code I'm not totally sure they work for publish as the code seems to quit before that.

I know that most of the sense here is to have it be valid by the schema, but with dates having to specify a day (jsonresume/resume-schema/#142) and dates that can not be left out for current, this simply isn't feasible for me.

For people with the same problem, try commenting out this line: https://github.com/jsonresume/resume-cli/blob/master/lib/waterfallArray.js#L73

I was thinking about fixing up a PR, but with the force option only available on program and that not being available in the waterfall scope (from what I can tell) that seems like some work. Happy to cook up a PR if good advice flies in.

@mchelen
Copy link
Member

mchelen commented Nov 13, 2014

Want to test this PR and see if it works? #62

@mchelen mchelen added this to the Suggested Milestone milestone Nov 20, 2014
@mchelen
Copy link
Member

mchelen commented Dec 20, 2014

Should be fixed by #62

@mchelen mchelen closed this as completed Dec 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants