Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports for 5.2.10: Fixes in build process and PHP 8 #631

Merged
merged 7 commits into from
May 27, 2020
Merged

Backports for 5.2.10: Fixes in build process and PHP 8 #631

merged 7 commits into from
May 27, 2020

Conversation

Ayesh
Copy link

@Ayesh Ayesh commented May 16, 2020

Closes #626

Backported PRs

Cherry-picked commits related to build process and build warnings that this library often trigger in various Composer projects. No API changes.

@Seldaek
Copy link
Contributor

Seldaek commented May 26, 2020

@erayd @bighappyface sorry to nag here but is there any chance to get this moved forward and get a new 5.x release soon? It's blocking Composer progress on PHP 8 support and incidentally triggers errors for everyone else relying on Composer to install packages on PHP 8. Hence the urgency.

I'm also happy to help and do it myself if someone can grant me access. I don't have enough knowledge about the internals here to do much work but handling a backport release seems fine.

@erayd
Copy link
Contributor

erayd commented May 26, 2020

I'll try to get this done today. It's just backports, so shouldn't take too long.

Can't give you access unfortunately; the only person who can do that is @justinrainbow, and he very rarely responds to anything at all.

@bighappyface bighappyface changed the title Backports for 5.2.9: Fixes in build process and PHP 8 Backports for 5.2.10: Fixes in build process and PHP 8 May 27, 2020
@bighappyface bighappyface merged commit 2ba9c8c into jsonrainbow:5.x.x May 27, 2020
@bighappyface
Copy link
Collaborator

@Seldaek pushed out 5.2.10 release. Let me know things are good to go.

@erayd
Copy link
Contributor

erayd commented May 27, 2020

@bighappyface Looks like you beat me to it! Thank you 😁.

@Seldaek
Copy link
Contributor

Seldaek commented May 27, 2020

Great, thanks folks! For this and for your continued work on this project 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants