-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backports for 5.2.10: Fixes in build process and PHP 8 #631
Conversation
This fixes issue #618
* Test on PHP 7.4 and HHVM (3.18 explicitly) * Update .travis.yml
@erayd @bighappyface sorry to nag here but is there any chance to get this moved forward and get a new 5.x release soon? It's blocking Composer progress on PHP 8 support and incidentally triggers errors for everyone else relying on Composer to install packages on PHP 8. Hence the urgency. I'm also happy to help and do it myself if someone can grant me access. I don't have enough knowledge about the internals here to do much work but handling a backport release seems fine. |
I'll try to get this done today. It's just backports, so shouldn't take too long. Can't give you access unfortunately; the only person who can do that is @justinrainbow, and he very rarely responds to anything at all. |
@Seldaek pushed out 5.2.10 release. Let me know things are good to go. |
@bighappyface Looks like you beat me to it! Thank you 😁. |
Great, thanks folks! For this and for your continued work on this project 👍 |
Closes #626
Backported PRs
Cherry-picked commits related to build process and build warnings that this library often trigger in various Composer projects. No API changes.