Backport PHP 8 function signature fixes to 5.x.x branch #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…optional parameters. This is related to #619, where the fix was applied on the master branch. This commit backports them to 5.x.x branch. From PHP 8.0 and forwards, a deprecation notice is raised if there are required parameters after optional parameters in a function/method signature. See https://php.watch/versions/8.0/deprecate-required-param-after-optional for details.
|
If you are going to do backports, can you please do them in the same manner as previous backport PRs. I normally do one every few months - if you take a look at the 5.x.x branch, you'll see what I mean. I'm happy to tag a new release once the backporting is done. |
|
👍 This is particularly important for composer which uses this dependency, and this warning is raised on every run. |
|
// cc @Seldaek |
|
I opened #631 containing all PHP 8, CI, and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Justin,
I noticed a few deprecation notices when running some tests PHP 8 master builds, and I discovered the recently merged #619 that contains the same fix for it. It was made against the master branch. Here is a PR to backport them to 5.x.x branch, which majority of the dependents currently use. Hopefully we can have a tagged release in 5.x series too :)
Cheers.