Added note about supported Draft versions #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I got started working with this library I got frustrated when my Schema didn't work as expected. It wasn't until I looked at the test files that I realized I was using features of a Draft that was not supported by this library. A note like the one I added would have saved me a lot of time trying to debug my Schema. So I am adding it now for everyone that comes after me.
|
Hi @erayd |
|
@yannickroger I would love to merge this too, but I get the feeling that because of the failed tests, this PR doesnt get so much attention. Unfortunately. I don't really get what error is occuring. I suspect it is something with the php linter, but looking at the logs I am not even sure where the error is. It shouldn't matter however, as I just touched the Readme. I'll still try to keep this up to date. |
erayd
approved these changes
Jun 20, 2020
|
@janlucaklees Yep, just the style linter. @yannickroger Thanks for reminding me about this PR - it's now merged 🙂. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I got started working with this library I got frustrated when my Schema didn't work as expected. It wasn't until I looked at the test files that I realized I was using features of a Draft that was not supported by this library. A note like the one I added would have saved me a lot of time trying to debug my Schema.
So I am adding it now for everyone that comes after me.
This PR is a result of #617