Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify supported JSON Schema version #617

Closed
janlucaklees opened this issue Feb 26, 2020 · 3 comments
Closed

Specify supported JSON Schema version #617

janlucaklees opened this issue Feb 26, 2020 · 3 comments

Comments

@janlucaklees
Copy link
Contributor

I would love to see the actual JSON Schema version that is supported by the library somewhere in the readme. Sure I can go look in the tests and infer that only Draft-4 of the JSON Schema is supported, but you need to be very desperate to do that.

Context: I spent a whole lot of time figuring out why 'contains' is not working for an array. Not sure, but maybe with Constraint::CHECK_MODE_VALIDATE_SCHEMA set, it should warn you about properties in your JSON Schema that are not supported.

I would be open to "implement" those changes myself and open a PR for them to be merged.

@erayd
Copy link
Contributor

erayd commented Feb 26, 2020

Good suggestion. A PR for this would be appreciated :-).

@yannickroger
Copy link

@erayd @janlucaklees I think we can close that one 😉

@janlucaklees
Copy link
Contributor Author

@yannickroger Yess, thank you for reminding me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants