Skip to content

Commit

Permalink
gitignore /.nyc-output, /node_modules, /package-lock.json
Browse files Browse the repository at this point in the history
These files materialize after running `npm install` and `npm run test`.
Adding them to `.gitignore` to reduce friction for developers and to
help ensure that they are not accidentally committed.

I found this discussion from a few years ago that seems relevant:

#58 (comment)

While I agree with the sentiment of something so universal being a
ignored by default globally, since it is not the default git behavior in
practice it makes it more difficult for people to contribute to this
repo. The cost of adding these lines to `.gitignore` is low, so this
seems like a reasonable change to make.

I was surprised that this was not already the case, and since this seems
to be a common issue in this repo, it seems that other developers are
also surprised by this.

- #23
- #26
  • Loading branch information
lencioni committed Oct 26, 2022
1 parent 42aae52 commit 8da1ac7
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
**/.package-lock.json
/.nyc-output
/node_modules
/package-lock.json

0 comments on commit 8da1ac7

Please sign in to comment.