add a gitignore file to prevent node modules from being committed #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Strongly recommend https://help.github.com/articles/ignoring-files/#create-a-global-gitignore! git config --global core.excludesfile ~/.gitignore_global
grep --fixed-strings node_modules ~/.gitignore_global || echo node_modules >> ~/.gitignore_global |
lencioni
added a commit
to lencioni/licensee.js
that referenced
this pull request
Oct 26, 2022
These files materialize after running `npm install`. Adding them to `.gitignore` to reduce friction for developers and to help ensure that they are not accidentally committed. I found this discussion from a few years ago that seems relevant: jslicense#58 (comment) While I agree with the sentiment of something so universal being a ignored by default globally, since it is not the default git behavior in practice it makes it more difficult for people to contribute to this repo. The cost of adding these lines to `.gitignore` is low, so this seems like a reasonable change to make. I was surprised that this was not already the case, and since this seems to be a common issue in this repo, it seems that other developers are also surprised by this. - jslicense#23 - jslicense#26
lencioni
added a commit
to lencioni/licensee.js
that referenced
this pull request
Oct 26, 2022
These files materialize after running `npm install` and `npm run test`. Adding them to `.gitignore` to reduce friction for developers and to help ensure that they are not accidentally committed. I found this discussion from a few years ago that seems relevant: jslicense#58 (comment) While I agree with the sentiment of something so universal being a ignored by default globally, since it is not the default git behavior in practice it makes it more difficult for people to contribute to this repo. The cost of adding these lines to `.gitignore` is low, so this seems like a reasonable change to make. I was surprised that this was not already the case, and since this seems to be a common issue in this repo, it seems that other developers are also surprised by this. - jslicense#23 - jslicense#26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.