[pr2eus/robot-interface.l] update actionlib name of default controller. #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In my opinion, start-jsk/rtmros_common#970 is better because of start-jsk/rtmros_common#970 (comment) and start-jsk/rtmros_common#970 (comment). |
|
My opinion changed, and maybe this PR should be mearged. (and start-jsk/rtmros_common#970 should be closed?) |
|
@mmurooka start-jsk/rtmros_common#970, はマージされていないように見えますが，どこでこれが必要になるでしょうか． |
|
確かにこれがないと，latestのhrpsys_ros_bridge は動かない． |
|
ああ，ちがうか．#237の影響ということか． |
そうです． |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #237 (comment) and start-jsk/rtmros_common#970 (comment).
one of this PR or start-jsk/rtmros_common#970 should be merged.
check result of whether hrp2jsk-init works or not: