Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_topic_tools] Some fixes following #1446 #1447

Merged
merged 4 commits into from
Aug 30, 2016

Conversation

wkentaro
Copy link
Member

@wkentaro wkentaro commented Aug 26, 2016

Some fixes are necessary for #1446.

Contains following fixes

  • Use project exported library for linking target library

For simplicity and to make it easy to add another configurations for testing.

  • Add ::test namespace to avoid conflicts of nodelet class name

If links project exported library, the nodelet class name can conflicts (in the future), so this is necessary.

  • Rename to have log_utils in the filename

IMO tests for log_utils.cpp should be log_utils in the filename without any specific reasons.

  • Nodelet should be have suffix of _nodelet

This is a standard name rule in ROS, for example:

@wkentaro wkentaro changed the title [jsk_topic_tools] Some fixes following #1446 - Use project exported library for linking target library [jsk_topic_tools] Some fixes following #1446 Aug 26, 2016
@k-okada k-okada merged commit 20bab21 into jsk-ros-pkg:master Aug 30, 2016
@wkentaro wkentaro deleted the fix-1446 branch August 30, 2016 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants