[jsk_topic_tools] add JSK_NODELET_LOG_THROTTLE

[furushchev]

No description provided.

[wkentaro]

Is add_rostest_gtest() not usable?

[furushchev]

@wkentaro I did not know just how to test by add_rostest_gtest.

[wkentaro]

I suppose you can do like this:
https://github.com/jsk-ros-pkg/jsk_common/blob/master/jsk_topic_tools/CMakeLists.txt#L126-L127

[wkentaro]

Actually, I found the JSK_ROS_XXX logging macros are not necessary just recently.
Its feature is already covered by ROSCONSOLE_FORMAT environmental variable.
http://wiki.ros.org/rosconsole#Console_Output_Formatting
(you can try it by running export ROSCONSOLE_FORMAT='[${node}] [${function}] [${severity}] [${time}]: ${message}')

I agree that we add this function to jsk_topic_tools at this time, but we should add deprecation warning for all of the logging functions.
like below

Deprecation warning: JSK_ROS_XXX is being deprecated, please consider customize rosconsole output by using ROSCONSOLE_FORMAT environmental variable. See http://wiki.ros.org/rosconsole#Console_Output_Formatting for more details.

[k-okada]

I agree that we add this function to jsk_topic_tools at this time, but we should add deprecation warning for all of the logging functions.

why we have to add this function at this time, for hydro?

[wkentaro]

@k-okada It is not necessary. But currently there are already logging macros: JSK_ROS_XXX, JSK_ROS_XXX_STREAM, JSK_ROS_XXX_THROTTLE, JSK_ROS_XXX_STREAM_THROTTLE, JSK_NODELET_XXX, and JSK_NODELET_XXX_STREAM, so I think some users expect JSK_NODELET_XXX_THROTTLE and JSK_NODELET_XXX_STREAM_THROTTLE are also supported, and it is better that we add deprecation warning for them at this time and will remove all macros at once in the next major release. What do you think?

[k-okada]

I see, Since we already noticed that JSK_XXX logging macro is no longer needed, so we can create PR that display deprecation warning for these macros