Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- jsk_tools/src/test_topic_published.py: set default timeout to 10 sec #1372

Merged
merged 2 commits into from
May 1, 2016

Conversation

k-okada
Copy link
Member

@k-okada k-okada commented Apr 18, 2016

  • jsk_tools/src/test_topic_published.py: set default timeout to 10 sec
  • jsk_tools/src/sanity_lib.py: add timouetout informatoin

@k-okada k-okada changed the title - jsk_tools/src/test_topic_published.py: set default timeout to 10 sec - jsk_tools/src/sanity_lib.py: add timouetout informatoin - jsk_tools/src/test_topic_published.py: set default timeout to 10 sec Apr 26, 2016
@k-okada
Copy link
Member Author

k-okada commented Apr 26, 2016

@wkentaro , please review

@@ -55,7 +55,7 @@ def __init__(self, topic_name, timeout=5, echo=False, data_class=None):
self.launched_time = rospy.Time.now()
self.first_time_callback = True
self.echo = echo
print " Checking %s" % (topic_name)
print " Checking %s at %d Hz" % (topic_name, timeout)
Copy link
Member

@wkentaro wkentaro Apr 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

" Checking %s for %d seconds" ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at -> for?

@k-okada k-okada force-pushed the update_test_topic_publihsed branch from fd077a1 to 5bbc93e Compare April 27, 2016 11:09
@k-okada k-okada force-pushed the update_test_topic_publihsed branch from 5bbc93e to ae66a5c Compare April 27, 2016 11:47
@wkentaro
Copy link
Member

LGTM

@k-okada k-okada merged commit db8edf9 into jsk-ros-pkg:master May 1, 2016
@k-okada k-okada deleted the update_test_topic_publihsed branch May 1, 2016 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants