Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jsk_tools] Use "$@" to pass arguments in git-jsk-commit #1347

Merged
merged 1 commit into from
Feb 12, 2016
Merged

[jsk_tools] Use "$@" to pass arguments in git-jsk-commit #1347

merged 1 commit into from
Feb 12, 2016

Conversation

wkentaro
Copy link
Member

Closes #1319

Modified:

  • jsk_tools/bin/git-jsk-commit

@wkentaro
Use "$@" to pass arguments in git-jsk-commit
d287acd 
Closes jsk-ros-pkg#1319

Modified:
  - jsk_tools/bin/git-jsk-commit
@wkentaro wkentaro changed the title Use "$@" to pass arguments in git-jsk-commit [jsk_tools] Use "$@" to pass arguments in git-jsk-commit Feb 11, 2016
@wkentaro
Copy link
Member Author

I confirmed below works:

git commit-wada = git jsk-commit --author="Kentaro Wada <[email protected]>"

@garaemon
Copy link
Member

does git commit-wada -m "foo bar" work?

@wkentaro
Copy link
Member Author

It works, I think.
screen shot 2016-02-11 at 11 44 46 pm

garaemon added a commit that referenced this pull request Feb 12, 2016
@garaemon
Merge pull request #1347 from wkentaro/fix-jsk-commit
2a13820 
[jsk_tools] Use "$@" to pass arguments in git-jsk-commit
@garaemon garaemon merged commit 2a13820 into jsk-ros-pkg:master Feb 12, 2016
@wkentaro wkentaro deleted the fix-jsk-commit branch March 11, 2016 12:25
@k-okada k-okada mentioned this pull request Jun 20, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkentaro @garaemon