Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jsk_tools] git-jsk-commit does not commit the files in parent directory of it is executed #1319

Closed
wkentaro opened this issue Dec 21, 2015 · 1 comment
Closed

[jsk_tools] git-jsk-commit does not commit the files in parent directory of it is executed #1319

wkentaro opened this issue Dec 21, 2015 · 1 comment

Comments

@wkentaro
Copy link
Member

image

staged files in upper directories are not included to the commit, do you have any idea about this?
@wkentaro
Copy link
Member Author

this appears after the change in #1302
with: https://github.com/jsk-ros-pkg/jsk_common/pull/1302/files#diff-86ba26bb99429276a04e3b204b0db63fR29

I don't know how we can support both feature.

wkentaro added a commit to wkentaro/jsk_common that referenced this issue Feb 11, 2016
@wkentaro
Use "$@" to pass arguments in git-jsk-commit
d287acd 
Closes jsk-ros-pkg#1319

Modified:
  - jsk_tools/bin/git-jsk-commit
@wkentaro wkentaro mentioned this issue Feb 11, 2016
Merged
@k-okada k-okada mentioned this issue Jun 20, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wkentaro