After #56 animations are not being cloned #72
Comments
jscastro76
added a commit
that referenced
this issue
Nov 2, 2020
Minor version by [@jscastro76](https://github.com/jscastro76), some enhancements and bugs. #### ✨ Enhancements - [**#24**](#24) Refactor `obj.deepCopy`, these members must be properties found by name - [**#54**](#54) vue and threebox,map not defined. - [**#63**](#63) `CSS2DObject` is not disposing properly. - [**#66**](#66) `tb.dispose` must now call `tb.clear` and return the async value - [**#68**](#68) add new methods to remove label & tooltip - [**#71**](#71) Defer default boundingBox and tooltip creation. - Update example [15-performance.html](https://github.com/jscastro76/threebox/blob/master/examples/15-performance.html) to avoid dupplicated calls when dragging the count GUI control. #### 🪲 Bug fixes - [**#61**](#61) `.userData` not refreshed properly on `obj.duplicate`. - [**#62**](#62) Memory Leak on `tb.remove()`. Tested - [**#64**](#64) Cache instance of a loaded model is disposed when the world children is. - [**#65**](#65) addTooltip and addLabel don't remove previous objects. - [**#67**](#67) clones have `boundingBoxShadow` line in white. - [**#69**](#69) After #56 the labels and tooltips are wrongly positioned. - [**#70**](#70) After #56 object boundingBox has the original cached size. - [**#72**](#72) After #56 animations are not being cloned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Also animations are a member that is storing a duplicate of the animation when that's not really needed as it can be a getter to
obj.model.animationsThe text was updated successfully, but these errors were encountered: