Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new methods to remove label & tooltip #68

Closed
jscastro76 opened this issue Oct 29, 2020 · 0 comments
Closed

add new methods to remove label & tooltip #68

jscastro76 opened this issue Oct 29, 2020 · 0 comments
Assignees
@jscastro76
Labels
📑 code improvement 🍏 feature New feature or request
Milestone
v2.0.7.

Comments

@jscastro76
Copy link
Owner

jscastro76 commented Oct 29, 2020 •
edited
Loading

Use also these methods to remove it from addLabel and addModel
Related to #65
@jscastro76 jscastro76 self-assigned this Oct 29, 2020
jscastro76 added a commit that referenced this issue Nov 2, 2020
@jscastro76
## 2.0.7
a99b82a 
Minor version by [@jscastro76](https://github.com/jscastro76), some enhancements and bugs.

#### ✨ Enhancements

- [**#24**](#24) Refactor `obj.deepCopy`, these members must be properties found by name
- [**#54**](#54) vue and threebox,map not defined.
- [**#63**](#63) `CSS2DObject` is not disposing properly.
- [**#66**](#66) `tb.dispose` must now call `tb.clear` and return the async value
- [**#68**](#68) add new methods to remove label & tooltip
- [**#71**](#71) Defer default boundingBox and tooltip creation.
- Update example [15-performance.html](https://github.com/jscastro76/threebox/blob/master/examples/15-performance.html) to avoid dupplicated calls when dragging the count GUI control.

#### 🪲 Bug fixes
- [**#61**](#61) `.userData` not refreshed properly on `obj.duplicate`.
- [**#62**](#62) Memory Leak on `tb.remove()`. Tested
- [**#64**](#64) Cache instance of a loaded model is disposed when the world children is.
- [**#65**](#65) addTooltip and addLabel don't remove previous objects.
- [**#67**](#67) clones have `boundingBoxShadow` line in white.
- [**#69**](#69) After #56 the labels and tooltips are wrongly positioned.
- [**#70**](#70) After #56 object boundingBox has the original cached size.
- [**#72**](#72) After #56 animations are not being cloned.
@jscastro76 jscastro76 added this to the v2.0.7. milestone Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jscastro76 jscastro76

Labels
📑 code improvement 🍏 feature New feature or request
Projects
None yet
Milestone
v2.0.7.
Development

No branches or pull requests
1 participant
@jscastro76