Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format code, add configs for ESLint and JSCS #13

Merged
merged 1 commit into from
Oct 14, 2015
Merged

Format code, add configs for ESLint and JSCS #13

merged 1 commit into from
Oct 14, 2015

Conversation

thorn0
Copy link
Contributor

@thorn0 thorn0 commented Oct 14, 2015

Closes #12

@jrit
Copy link
Owner

jrit commented Oct 14, 2015

Are there any functional changes to look at or just formatting? Assuming from the commit message it is the latter, but want to be sure.

Thanks for taking care of this 👍

@thorn0
Copy link
Contributor Author

thorn0 commented Oct 14, 2015

I also replaced string.match(regex) with regex.test(string) where it was possible.

BTW, JSCS doesn't fully support your code style because of a bug: jscs-dev/node-jscs#1820.

@jrit
Copy link
Owner

jrit commented Oct 14, 2015

test should be better where that was possible. Thanks again.

jrit added a commit that referenced this pull request Oct 14, 2015
@jrit
Merge pull request #13 from thorn0/format-code
01de7a9 
Format code, add configs for ESLint and JSCS
@jrit jrit merged commit 01de7a9 into jrit:master Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thorn0 @jrit