Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code style #12

Closed
thorn0 opened this issue Sep 30, 2015 · 3 comments
Closed

Code style #12

thorn0 opened this issue Sep 30, 2015 · 3 comments

Comments

@thorn0
Copy link
Contributor

thorn0 commented Sep 30, 2015

Preparing pull requests, I wanted to use JSCS to automate checking and fixing the code style. However, it turned out there are different code styles in src (Allman-style blocks, jQuery-style parentheses) and in test (K&R blocks, parentheses without padding). So which one is more preferable? I'd like to unify the code style to make further contributing to the project easier.
@jrit
Copy link
Owner

jrit commented Sep 30, 2015

Maybe just guess at what would be the least work to change and go from that. If you want to make style validation a requirement of npm test please feel free.

@thorn0
Copy link
Contributor Author

thorn0 commented Sep 30, 2015

It's exactly the same amount of work because it's JSCS (or maybe ESLint) that will format the code, not a human. So what I'm asking is which of the two styles we want to enforce.

@jrit
Copy link
Owner

jrit commented Sep 30, 2015

If you are asking me to pick, use the one in src

@thorn0 thorn0 mentioned this issue Oct 14, 2015
Merged
@jrit jrit closed this as completed in #13 Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thorn0 @jrit