Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require a space before the closing sequence of an atx heade #779

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Require a space before the closing sequence of an atx heade #779

merged 1 commit into from
Jul 21, 2023

Conversation

kuranari
Copy link
Contributor

@kuranari kuranari commented Jul 20, 2023 •
edited
Loading

Description

Whitespace is required before the closing sequence of an atx header.
https://spec.commonmark.org/0.30/#example-75

Related Issue

#778

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have updated the documentation in the README.md file if necessary.
  • I have added an entry to CHANGES.md.
  • I have added tests to cover my changes.
  • All new and existing tests passed (using make test).

@syohex syohex merged commit 35e2296 into jrblevin:master Jul 21, 2023
@syohex
Copy link
Collaborator

syohex commented Jul 21, 2023

Looks good. Thank you!!

@kuranari kuranari deleted the modify-markdown-regex-header branch July 21, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuranari @syohex