Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faulty recognition of closing sequence in atx headers #778

Closed
kuranari opened this issue Jul 20, 2023 · 0 comments
Closed

Faulty recognition of closing sequence in atx headers #778

kuranari opened this issue Jul 20, 2023 · 0 comments

Comments

@kuranari
Copy link
Contributor

kuranari commented Jul 20, 2023

Expected Behavior

  1. We want trailing spaces to be visible when markdown-hide-markup is enabled.
    • The current behavior results in an unnatural input experience(see the attached video for more details).
  2. The closing sequence must be preceded by a space or tab

Actual Behavior

  1. Trailing spaces are not visible when 'markdown-hide-markup' is enabled.
  2. A closing sequence is identified even without a trailing whitespace.

Steps to Reproduce

Input # foo# or ## Steps to Reproduce

default.mov

The whitespace appears when the next character is entered.

Software Versions

  • Markdown Mode: 2.6-alpha
  • Emacs: GNU Emacs 28.2
  • OS: macOS Ventura 13.3.1 (a)

Additional Details

The issue occurs due to the definition of markdown-regex-header.

Changes were introduced to align with the implementation of Markdown.pl as per this commit: 26e3937

While the behavior of the whitespace following the opening sequence was modified with this commit: 58ba6a3, the behavior of the whitespace preceding the closing sequence was not altered.

@kuranari kuranari changed the title Faulty recognition of Closing Sequence in Atx Headers Faulty recognition of closing sequence in atx headers Jul 20, 2023
@syohex syohex closed this as completed Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants