Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (e) to catch blocks #794

Closed
wants to merge 1 commit into from
Closed

Add (e) to catch blocks #794

wants to merge 1 commit into from

Conversation

loup-brun
Copy link

I know node v8 is not in the list of engines.
Nevertheless, this very minor fix avoids failing on node v8, where everything else works perfectly.

Basically, it’s just adding the (e) on catch blocks which don’t specify an exception var.

try {
  // ...
} catch (e) {}

This package is the only one failing on a very lightweight project, and my team finds it painful to download multiple node versions across projects (I don’t mind using NVM, but it’s still a lot of extra download)…

It would be very kind of you to integrate this small change.

This prevents node v8 from throwing an exception
@JPeer264
Copy link
Collaborator

JPeer264 commented May 5, 2020

Actually Node v8 has reached EOL. Since v9 we do not support Node v8 anymore, so you need to update to Node v10+ to use fs-extra v9+

@RyanZim feel free to reopen if there are any exceptions regarding this

@JPeer264 JPeer264 closed this May 5, 2020
@RyanZim
Copy link
Collaborator

RyanZim commented May 5, 2020

Yeah, Node v8 is EOL, so it should not be used, period. Also, the fact that fs-extra works on v8 otherwise is by chance, it may break further at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants