Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency issue with fs-extra #44

Closed
johnsickels opened this issue Jun 9, 2020 · 6 comments
Closed

Dependency issue with fs-extra #44

johnsickels opened this issue Jun 9, 2020 · 6 comments

Comments

@johnsickels
Copy link
Collaborator

This is a screenshot of my CircleCI build failing on an unexpected token from fs-extra. Cannot reproduce local.

Here, others are experiencing similar issues in Cloud Build, maybe others..
vercel/pkg#883

Screen Shot 2020-06-09 at 5 25 48 PM

Recommendation is to possibly roll back fs-extra to version 8..?

Node version 13.8.0
Flagpole version 2.4.9

@johnsickels
Copy link
Collaborator Author

@johnsickels
Copy link
Collaborator Author

I've tried all sorts of Node versions 10-14 (as a recommended solution in the original fs-extra issue above).

I've tried committing the compiled out/*.js and skipping the build step (since the issue seems to be near make-dir.js:85).

@alexanderbelokon-mway
Copy link

alexanderbelokon-mway commented Jun 29, 2020

Same for me on Mac OS 10.15.4

@jasonbyrne
Copy link
Collaborator

I haven't been able to reproduce this yet. Trying.

@jasonbyrne
Copy link
Collaborator

jasonbyrne commented Jul 3, 2020

Appears to be related to this: jprichardson/node-fs-extra#794

https://www.codespot.org/javascript-es2019-optional-catch-binding/

I'm not sure if there is anything I can do except strip out fs-extra dependency

@johnsickels
Copy link
Collaborator Author

Going to close as I haven't seen this lately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants