Webpack5 upgrade #1421

cristiano-belloni · 2022-02-21T15:15:48Z

Upgrade Webpack 4 -> Webpack 5.

Configuration similarities with CRA have been maintained where it makes sense.
Output file names are slightly changed (see tests) because now, for webpack 5, chunkFileName is only used for code splitting) (i.e. chunkFileName doesn't control vendor chunks; they're controlled by filename instead.
Removed optimize-css-assets-webpack-plugin and introduced css-minimizer-webpack-plugin as advised in optimize-css-assets-webpack-plugin's repo:

⚠️ For webpack v5 or above please use css-minimizer-webpack-plugin instead.

changeset-bot · 2022-02-21T15:15:52Z

🦋 Changeset detected

Latest commit: 41ded67

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
modular-scripts	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coveralls · 2022-02-24T15:43:50Z

Coverage decreased (-0.07%) to 28.09% when pulling 8816b88 on feature/experiment-webpack-5 into 85a831f on main.

…bpack-5

packages/modular-scripts/src/__tests__/app.test.ts

Bumps [lint-staged](https://github.com/okonet/lint-staged) from 12.3.6 to 12.3.7. - [Release notes](https://github.com/okonet/lint-staged/releases) - [Commits](lint-staged/lint-staged@v12.3.6...v12.3.7) --- updated-dependencies: - dependency-name: lint-staged dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [@types/react-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom) from 17.0.13 to 17.0.14. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-dom) --- updated-dependencies: - dependency-name: "@types/react-dom" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [node-forge](https://github.com/digitalbazaar/forge) from 1.2.1 to 1.3.0. - [Release notes](https://github.com/digitalbazaar/forge/releases) - [Changelog](https://github.com/digitalbazaar/forge/blob/main/CHANGELOG.md) - [Commits](digitalbazaar/forge@v1.2.1...v1.3.0) --- updated-dependencies: - dependency-name: node-forge dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.17.7 to 7.17.8. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.17.8/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 17.0.21 to 17.0.22. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 17.0.22 to 17.0.23. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 17.0.40 to 17.0.42. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) --- updated-dependencies: - dependency-name: "@types/react" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [postcss-preset-env](https://github.com/csstools/postcss-plugins/tree/HEAD/plugin-packs/postcss-preset-env) from 7.4.2 to 7.4.3. - [Release notes](https://github.com/csstools/postcss-plugins/releases) - [Changelog](https://github.com/csstools/postcss-plugins/blob/main/plugin-packs/postcss-preset-env/CHANGELOG.md) - [Commits](https://github.com/csstools/postcss-plugins/commits/HEAD/plugin-packs/postcss-preset-env) --- updated-dependencies: - dependency-name: postcss-preset-env dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [@testing-library/dom](https://github.com/testing-library/dom-testing-library) from 8.11.2 to 8.11.4. - [Release notes](https://github.com/testing-library/dom-testing-library/releases) - [Changelog](https://github.com/testing-library/dom-testing-library/blob/main/CHANGELOG.md) - [Commits](testing-library/dom-testing-library@v8.11.2...v8.11.4) --- updated-dependencies: - dependency-name: "@testing-library/dom" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Version Packages * Update release doc Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Cristiano Belloni <[email protected]>

…bpack-5

* fix node-12 incompatible javascript * Create thick-monkeys-kick.md

* Revert nodejs engine range * revert the dependabot upgrade of eslint-plugin-testing-library * Create gorgeous-seahorses-grin.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Fix bug that prevents lint diff code from running * Add changeset for lint diff bug Co-authored-by: Kathan Cheema <[email protected]>

* Mandate PRs to main to not be pre-releases * change name * Add check prerelease command as yarn script * test pre mode; this should fail * Revert "test pre mode; this should fail" This reverts commit 6570df0. * Allow release branches to trigger the release workflow * Add quotes and double glob to the branch rule * Activate tests for release branches and their PRs * Upgrade changeset action to v1 (master deprecated) * Enable static checks on release branches * revert cause github problems * Revert "revert cause github problems" This reverts commit 1718b73. * Use workflow to check pre-release * Test adding pre.json * Revert "Test adding pre.json" This reverts commit 838baaa. * Better workflow / job name * Add release branches to validate

…bpack-5

Cristiano Belloni added 4 commits February 18, 2022 16:28

Bring webpack configuration to a valid (but not working) state

c5c50db

webpack build working

f139c67

Remove sourcemap obsolete flag

a2c91cb

Redo ForkTsCheckerWebpackPlugin conf

3d3352d

Cristiano Belloni added 6 commits February 21, 2022 15:25

Fix stats type mismatch

5fcacfa

start.js

8fb8342

dev server working but trying to typecheck node_modules

b20e694

webpack start is working

bdfd0ec

Change css minimizer to remove deprecation

8986bd9

Remove diagnostics

9bd0894

cristiano-belloni changed the title ~~Experiment with Webpack5 upgrade~~ Webpack5 upgrade Feb 23, 2022

Cristiano Belloni added 2 commits February 24, 2022 14:54

Update snapshots

510fb6b

Support new version of minimize

92597a4

cristiano-belloni marked this pull request as ready for review February 24, 2022 16:21

Cristiano Belloni added 2 commits February 24, 2022 16:28

Add explaining comment

8bf2aea

Merge remote-tracking branch 'origin/main' into feature/experiment-we…

c6df324

…bpack-5

cristiano-belloni mentioned this pull request Feb 28, 2022

Build ESM views with external CDN support - esbuild & webpack 5 #1439

Merged

5 tasks

Cristiano Belloni and others added 9 commits February 28, 2022 16:54

Update yarn.lock

5a340d0

Merge remote-tracking branch 'origin/main' into feature/experiment-we…

3122acf

…bpack-5

Merge remote-tracking branch 'origin/main' into feature/experiment-we…

1f7a830

…bpack-5

Merge remote-tracking branch 'origin/main' into feature/experiment-we…

8b1f89b

…bpack-5

Update snapshots

f075c72

Update all snapshots

7c98350

Update snapshot hash

5f3c001

Add missing quotes

7b45909

Merge branch 'main' into feature/experiment-webpack-5

f97c6f2

LukeSheard reviewed Mar 11, 2022

View reviewed changes

packages/modular-scripts/src/__tests__/app.test.ts Outdated Show resolved Hide resolved

Remove unwanted media dist files

bc9cb4c

dependabot bot and others added 22 commits March 22, 2022 16:42

Relax our dependency criteria (#1503)

1a39571

Version Packages (#1261)

985a2d7

* Version Packages * Update release doc Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Cristiano Belloni <[email protected]>

Merge remote-tracking branch 'origin/main' into feature/experiment-we…

bd5e86b

…bpack-5

fix node-12 incompatible javascript (#1517)

22c2114

* fix node-12 incompatible javascript * Create thick-monkeys-kick.md

Revert engine range (#1518)

d896289

* Revert nodejs engine range * revert the dependabot upgrade of eslint-plugin-testing-library * Create gorgeous-seahorses-grin.md

Version Packages (#1519)

1503e78

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Fix bug that prevents lint diff code from running (#1510)

4846d21

* Fix bug that prevents lint diff code from running * Add changeset for lint diff bug Co-authored-by: Kathan Cheema <[email protected]>

Merge remote-tracking branch 'origin/main' into feature/experiment-we…

5a6dfdc

…bpack-5

Update snapshots

47e1ec4

Update build snapshots

64f46f7

Update browser versions

41ded67

steveukx approved these changes Mar 29, 2022

View reviewed changes

cristiano-belloni merged commit b2ca58b into release/webpack-5 Mar 29, 2022

cristiano-belloni deleted the feature/experiment-webpack-5 branch March 29, 2022 14:59

github-actions bot mentioned this pull request Mar 29, 2022

Version Packages (alpha-webpack5) #1521

Merged

This was referenced Apr 7, 2022

Version Packages #1553

Closed

Version Packages #1579

Closed

This was referenced Apr 28, 2022

[BREAKING/V3] Upgrade to webpack 5 #1649

Closed

[BREAKING/v3] Upgrade to webpack 5 #1650

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Webpack5 upgrade #1421

Webpack5 upgrade #1421

cristiano-belloni commented Feb 21, 2022 •

edited

Loading

changeset-bot bot commented Feb 21, 2022 •

edited

Loading

coveralls commented Feb 24, 2022 •

edited

Loading

Webpack5 upgrade #1421

Webpack5 upgrade #1421

Conversation

cristiano-belloni commented Feb 21, 2022 • edited Loading

changeset-bot bot commented Feb 21, 2022 • edited Loading

🦋 Changeset detected

coveralls commented Feb 24, 2022 • edited Loading

cristiano-belloni commented Feb 21, 2022 •

edited

Loading

changeset-bot bot commented Feb 21, 2022 •

edited

Loading

coveralls commented Feb 24, 2022 •

edited

Loading