Fix bug that prevents lint diff code from running

[cheemcheem]

It seems that the intended functionality is that if modular lint is run without '--all', in a non-ci environment, and without any file regex parameters, then the 'diff' code will be executed and only the changed files between the default branch and the current branch will be linted.

Currently however, the check for these conditions is faulty and the diff code is never executed.

This is due to a bug on line 26 / line 19, where on line 19 regexes is set to an empty array by default and never has the opportunity to be falsy. Then on line 26, it checks whether regexes is falsy before proceeding with the diff code.

My proposed change is that instead of checking whether regexes is falsy, it should check that the regexes array is empty since it can never be falsy.

Further reading about default parameters: TypeScript Docs.

[changeset-bot]

🦋 Changeset detected

Latest commit: 32e7022

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
modular-scripts	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coveralls]

Coverage remained the same at 28.742% when pulling 32e7022 on cheemcheem:feature/fix-lint-diff into 985a2d7 on jpmorganchase:main.