Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove default value override, set property explicitly, fixes #175 #178

Closed
wants to merge 1 commit into from
Closed

remove default value override, set property explicitly, fixes #175 #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions jupyterfs/metamanager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
import json
import re

from traitlets import default
from tornado import web

from fs.errors import FSError
Expand All @@ -36,8 +35,13 @@
class MetaManager(AsyncContentsManager):
copy_pat = re.compile(r"\-Copy\d*\.")

@default("files_handler_params")
def _files_handler_params_default(self):
# https://github.com/jpmorganchase/jupyter-fs/issues/175
# @default("files_handler_params")
# def _files_handler_params_default(self):
# return {"path": self.root_dir}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to keep this here and not just let the git(hub) history remember it for us?


@property
def files_handler_params(self):
return {"path": self.root_dir}

def __init__(self, **kwargs):
Expand Down
Loading