remove default value override, set property explicitly, fixes #175 #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
==========================================
- Coverage 37.86% 37.83% -0.04%
==========================================
Files 31 31
Lines 1965 1964 -1
Branches 312 312
==========================================
- Hits 744 743 -1
Misses 1119 1119
Partials 102 102
☔ View full report in Codecov by Sentry. |
vidartf
approved these changes
Nov 1, 2023
vidartf
reviewed
Nov 1, 2023
| # https://github.com/jpmorganchase/jupyter-fs/issues/175 | ||
| # @default("files_handler_params") | ||
| # def _files_handler_params_default(self): | ||
| # return {"path": self.root_dir} |
There was a problem hiding this comment.
Is there a reason to keep this here and not just let the git(hub) history remember it for us?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.