-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SubmissionCollection moves #231
Conversation
4e1f36f
to
ce7fb27
Compare
New version, less involved than the previous try. I contemplated whether to move the |
I like the changes in this PR. I checked out this branch and I think I found a way to reasonably move most of the parsing code into the submission set (basically separating the error reporting capabilities defined by |
I had a go too, created a new |
I also removed the error collecting from the program and changed the language frontend dependencies to no longer reference the main class. However, I think it is better to leave the language in the options, due to other features that are currently worked at. These changes do not affect the report generation. Maybe you can take a look at #234, if it is okay with you I would go ahead with that approach (so first merge #231 and then #234). |
Introducing a
SubmissionCollection
and moving common part of submission parsing toSubmission
.This is stacked on top of #230 but much bigger, and it may need some tweaking or discussing before it's good. Don't merge before #230 I'd say.
As explained in #230, I am having a fight with Java versions and maven.
I didn't do testing beyond running maven that includes some tests.