Streamline submission filtering and submission error handling #232
Labels
enhancement
Issue/PR that involves features, improvements and other changes
minor
Minor issue/feature/contribution/change
Milestone
Currently, there are multiple ways how submissions are excluded. Some are removed during iterating while parsing (see
JPlag.parseSubmissions()
), while others are marked as erroneous and then later filtered in a later step. We should streamline this process.As pointed out by @Alberth289346 in #230:
In my opinion, submissions should be marked as erroneous and maybe even given the information why they are erroneous. Then, they should be filtered later on. If we introduce a submission set (i.e. with #231), this could be done in there resulting in two methods:
getValidSubmissions()
andgetInvalidSubmissions()
. The latter is also useful for the new report generation, as the currentJPlagResult
does not expose which submissions were not used for comparison.The text was updated successfully, but these errors were encountered: