Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum report viewer version to 4.2.0 #1578

Merged
merged 2 commits into from
Feb 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion report-viewer/src/model/factories/OverviewFactory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ export class OverviewFactory extends BaseFactory {
"The result's version(" +
jsonVersion.toString() +
') is older than the minimal support version of the report viewer(' +
reportViewerVersion.toString() +
minimalVersion.toString() +
'). ' +
'Can not read the report.'
)
Expand Down
2 changes: 1 addition & 1 deletion report-viewer/src/router/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ function redirectOnError(
router.push({
name: 'ErrorView',
params: {
message: prefix + error.message,
message: prefix + (error.message ?? error),
to: redirectRoute,
routerInfo: redirectRouteTitle
}
Expand Down
4 changes: 2 additions & 2 deletions report-viewer/src/version.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
{
"report_viewer_version": {
"major": 0,
"major": 5,
"minor": 0,
"patch": 0
},
"minimal_report_version": {
"major": 4,
"minor": 0,
"minor": 2,
"patch": 0
}
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"jplag_version": { "major": 4, "minor": 0, "patch": 0 },
"jplag_version": { "major": 5, "minor": 0, "patch": 0 },
"submission_folder_path": ["files"],
"base_code_folder_path": "",
"language": "Javac based AST plugin",
Expand Down