Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum report viewer version to 4.2.0 #1578

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Feb 20, 2024

As discovered in #1565 the report viewer is not compatible with version 4.1.0 and lower. Thus the minimal version for the report viewer is now set to 4.2.0

In addition fixed a mistake in giving the wrong reference version in the error message
Fixed the error not being correctly passed to its view

@Kr0nox Kr0nox added the report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies label Feb 20, 2024
Copy link

Quality Gate Passed Quality Gate passed for 'JPlag Report Viewer'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tsaglam tsaglam added bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change labels Feb 20, 2024
@tsaglam tsaglam merged commit b32ecd6 into develop Feb 20, 2024
16 checks passed
@Kr0nox Kr0nox deleted the report-viewer/min-version branch February 23, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants