moved col length checks to cover multi.panel = T as well as being num… #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tbh, im not sure if we even need to check for mlti.panel. is there any harm in just doing this recycling for all scenarios? |
apply input recycling in all scenarios
|
Thanks for the PR! I just added a commit that removed some later checks on the length of 'col', 'lty', and 'lwd' so they're only in one place in |
|
hmm, im getting an error in |
|
Can you give me an example so I can take a look too? |
x <- as.xts(sample_matrix)
plot(x, multi.panel = TRUE)
addEventLines(xts("a", index(x)[10]), pos = 2:3)
seems to only be drawing on |
|
That's a bug, but not related to these changes. It's in the prior version on CRAN (0.14.0). EDIT: Actually, it's a bug in the example in the documentation. There's no 'pos' argument to library(xts)
data(sample_matrix)
sample.xts <- as.xts(sample_matrix)
events <- xts(letters[1:3],
as.Date(c("2007-01-12", "2007-04-22", "2007-06-13")))
plot(sample.xts[,4])
addEventLines(events, srt = 90, pos = 2) |
|
sry, should be |
|
working fine. all issues were on my end |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Nov 24, 2024
# xts 0.14.x (202x-xx-xx) * `plot.xts()` now renders all panels when 'x' has more than 8 columns and `multi.panel = TRUE`. Columns 9 and later didn't render because the default of `plot.xts()` is 'col = 1:8'. Thanks to Ethan Smith for the report and patch. ([#423](joshuaulrich/xts#423)) ([#424](joshuaulrich/xts#424)) * `plot.xts()` no longer errors when 'ylim' is constant and negative. Thanks to Ethan Smith for the report. ([#422](joshuaulrich/xts#422)) * Do not use `SET_TYPEOF()` in C because it is not part of the public R API. * `merge.xts()` no longer converts 'x' or 'y' from double to integer in the C code when they are not used in the result. This avoids an unnecessary and confusing warning. Thanks to Jeff Ryan for the report. # xts 0.14.0 (2024-06-05) * `addEventLines()` and `addLegend()` now draw on multiple panels when `on` is a vector. Thanks to Ethan Smith for the report. ([#420](joshuaulrich/xts#420)) * Replace `SET_TYPEOF()` in merge.c because it will error when it tries to convert a REAL to an INTEGER. Thanks to Kurt Hornik for the report! ([#419](joshuaulrich/xts#419)) * Fix crash when 'j' is not an integer and in [0, 1) (e.g. `j = 0.1`). Also throw a warning when 'j' is not an integer. ([#413](joshuaulrich/xts#413)) ([#415](joshuaulrich/xts#415)) * Fix plot header when `layout()` is used to draw multiple plots on a single device. Thanks to Dirk Eddelbuettel for the report and testing! ([#412](joshuaulrich/xts#412)) * Fix plot legend location when the y-axis is log scale. ([#407](joshuaulrich/xts#407)) # xts 0.13.2 (2024-01-21) * Print a message when `period.apply()` is called with `FUN = mean` because it calculates the mean for each column, not all the data in the subset like it does for all other functions. The message says to use `FUN = colMeans` for current behavior and `FUN = function(x) mean(x)` to calculate the mean for all the data. This information is also included in the help files. The option `xts.message.period.apply.mean = FALSE` suppresses the message. ([#124](joshuaulrich/xts#124)) * Fix error when `print.xts()` is called 'quote' or 'right' arguments. ([#401](joshuaulrich/xts#401)) * Fix `addPolygon()` so it renders when `observation.based = TRUE`. ([#403](joshuaulrich/xts#403)) * Print trailing zeros for index value with fractional seconds, so every index value has the same number of characters. ([#404](joshuaulrich/xts#404)) * Add ability to log scale the y-axis in `plot.xts()`. ([#103](joshuaulrich/xts#103)) * Actually change the underlying index values when 'tclass' is changed from a class with a timezone (e.g. POSIXct) to one without a timezone (e.g. Date). Add a warning when this happens, with a global option to always suppress the warning. ([#311](joshuaulrich/xts#311)). * Significantly refactor the internals of `plot.xts()`. ([#408](joshuaulrich/xts#408))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moved input length checks up in flow to cover both (multi.panel == TRUE) and (is.numeric(multi.panel))
fixes #423