Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subset column with numeric value 0 <= j < 1 causes segfault #413

Closed
joshuaulrich opened this issue Jan 31, 2024 · 0 comments
Closed

subset column with numeric value 0 <= j < 1 causes segfault #413

joshuaulrich opened this issue Jan 31, 2024 · 0 comments
Assignees
@joshuaulrich
Labels
bug
Milestone
0.14.0

Comments

@joshuaulrich
Copy link
Owner

Yes this is silly, but it shouldn't crash the R session.

require(xts)
data(sample_matrix)
x <- as.xts(sample_matrix)
x[, 0.1]
@joshuaulrich joshuaulrich self-assigned this Jan 31, 2024
joshuaulrich added a commit that referenced this issue Feb 6, 2024
@joshuaulrich
Ensure 'i' is integer and warn if it isn't
ef2a103 
Convert 'i' to integer in the R code to avoid issues when it's passed
to the C code. I couldn't get this to crash like I could with the code
for 'j', but it caused incorrect results when values in 'i' were set
to zero during conversion to integer.

See #413.
@joshuaulrich joshuaulrich mentioned this issue Feb 6, 2024
Closed
joshuaulrich added a commit that referenced this issue Feb 6, 2024
@joshuaulrich
Warn when 'i' or 'j' is negative non-integer
48cc21a 
We need to convert 'i' and 'j' to integer if they're numeric with a
fractional component. This was only being done when 'i' and 'j' were
positive.

Also fix the if-statement. sum() could have returned NA and it's better
to use isTRUE() and any() anyway.

Fixes #415. See #413.
@joshuaulrich joshuaulrich added this to the Next release milestone Jun 3, 2024
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Nov 24, 2024
(math/R-xts) Updated 0.13.1 to 0.14.1
3e167f0 
# xts 0.14.x (202x-xx-xx)

* `plot.xts()` now renders all panels when 'x' has more than 8 columns and
  `multi.panel = TRUE`. Columns 9 and later didn't render because the default
  of `plot.xts()` is 'col = 1:8'. Thanks to Ethan Smith for the report and
  patch.
  ([#423](joshuaulrich/xts#423))
  ([#424](joshuaulrich/xts#424))

* `plot.xts()` no longer errors when 'ylim' is constant and negative. Thanks
  to Ethan Smith for the report.
  ([#422](joshuaulrich/xts#422))

* Do not use `SET_TYPEOF()` in C because it is not part of the public R API.

* `merge.xts()` no longer converts 'x' or 'y' from double to integer in the C
  code when they are not used in the result. This avoids an unnecessary and
  confusing warning. Thanks to Jeff Ryan for the report.

# xts 0.14.0 (2024-06-05)

* `addEventLines()` and `addLegend()` now draw on multiple panels when `on` is
  a vector. Thanks to Ethan Smith for the report.
  ([#420](joshuaulrich/xts#420))

* Replace `SET_TYPEOF()` in merge.c because it will error when it tries to
  convert a REAL to an INTEGER. Thanks to Kurt Hornik for the report!
  ([#419](joshuaulrich/xts#419))

* Fix crash when 'j' is not an integer and in [0, 1) (e.g. `j = 0.1`). Also
  throw a warning when 'j' is not an integer.
  ([#413](joshuaulrich/xts#413))
  ([#415](joshuaulrich/xts#415))

* Fix plot header when `layout()` is used to draw multiple plots on a single
  device. Thanks to Dirk Eddelbuettel for the report and testing!
  ([#412](joshuaulrich/xts#412))

* Fix plot legend location when the y-axis is log scale.
  ([#407](joshuaulrich/xts#407))

# xts 0.13.2 (2024-01-21)

* Print a message when `period.apply()` is called with `FUN = mean` because it
  calculates the mean for each column, not all the data in the subset like it
  does for all other functions. The message says to use `FUN = colMeans` for
  current behavior and `FUN = function(x) mean(x)` to calculate the mean for
  all the data. This information is also included in the help files. The option
  `xts.message.period.apply.mean = FALSE` suppresses the message.
  ([#124](joshuaulrich/xts#124))

* Fix error when `print.xts()` is called 'quote' or 'right' arguments.
  ([#401](joshuaulrich/xts#401))

* Fix `addPolygon()` so it renders when `observation.based = TRUE`.
  ([#403](joshuaulrich/xts#403))

* Print trailing zeros for index value with fractional seconds, so every index
  value has the same number of characters.
  ([#404](joshuaulrich/xts#404))

* Add ability to log scale the y-axis in `plot.xts()`.
  ([#103](joshuaulrich/xts#103))

* Actually change the underlying index values when 'tclass' is changed from a
  class with a timezone (e.g. POSIXct) to one without a timezone (e.g. Date).
  Add a warning when this happens, with a global option to always suppress the
  warning.
  ([#311](joshuaulrich/xts#311)).

* Significantly refactor the internals of `plot.xts()`.
  ([#408](joshuaulrich/xts#408))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshuaulrich joshuaulrich

Labels
bug
Projects
None yet
Milestone
0.14.0
Development

No branches or pull requests
1 participant
@joshuaulrich