Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homebrew formulae for Joshua #195

Closed
lewismc opened this issue May 10, 2015 · 22 comments
Closed

Homebrew formulae for Joshua #195

lewismc opened this issue May 10, 2015 · 22 comments

Comments

@lewismc
Copy link
Contributor

lewismc commented May 10, 2015

I said a while back I would work on a Homebrew package for Joshua. This ticket is an attempt to honor that so I will make an effort to hack this one out.

@mjpost
Copy link
Member

mjpost commented May 11, 2015

Sounds great!

@lewismc
Copy link
Contributor Author

lewismc commented May 11, 2015

Began working this afternoon. Will hopefully finish tomorrow Matt. Will
update here ASAP.

On Sunday, May 10, 2015, Matt Post [email protected] wrote:

Sounds great!


Reply to this email directly or view it on GitHub
#195 (comment)
.

Lewis

@chrismattmann
Copy link
Contributor

@lewismc do you have something I can work from here?

@lewismc
Copy link
Contributor Author

lewismc commented Jun 19, 2015

Yep I do, the PR is not for Joshua it is for home brew
I'll send what I have shortly...

On Friday, June 19, 2015, Chris Mattmann [email protected] wrote:

@lewismc https://github.com/lewismc do you have something I can work
from here?


Reply to this email directly or view it on GitHub
#195 (comment)
.

Lewis

@chrismattmann
Copy link
Contributor

cool, thanks.

@lewismc
Copy link
Contributor Author

lewismc commented Sep 26, 2015

Took me way to long but this is now nearly off of my TODO list.
Homebrew/legacy-homebrew#44371
Sorry about the wait folks. The formula will work with a number of options namely;

lmcgibbn@LMC-032857 /usr/local(joshua) $ brew options joshua-v
--with-ar-en-phrase-pack
    Build with Arabic–English phrase-based model [2.4 GB], built from the LDC Arabic-Dialect/English parallel text, the ISI Arabic–English automatically extracted parallel text, and translations of the Arabic CALLHOME transcripts, and with an English Gigaword language model.
--with-es-en-phrase-pack
    Build with Spanish–English phrase-based model [1.9 GB], built on Europarl and the Fisher and CALLHOME parallel dataset.
--with-language-packs
    Build with all available community language packs (es-->en and ar-->en)
--HEAD
    Install HEAD version

The package is called joshua-v due to the published artifact being called joshua-v${release.number}.tar.gz. This is outwith my control.

@mjpost
Copy link
Member

mjpost commented Sep 29, 2015

Thanks! This looks great (though too bad about the name).

How hard is this to update when new versions of Joshua come out? 6.0.5 will be out soon with a number of speed improvements and bug fixes.

@lewismc
Copy link
Contributor Author

lewismc commented Sep 29, 2015

Hi Matt,
If you can change the .tar.gz to 6.0.5.tar.gz instead of v6.0.5.
If you can do this then it will be automatic as I'll update the formula to
resolve to the new correct tar.gz file.
I'll update here once the Formula has been merged.
Thanks

On Tue, Sep 29, 2015 at 2:48 PM, Matt Post [email protected] wrote:

This looks great, though too bad about the name.

How hard is this to update when new versions of Joshua come out? 6.0.5
will be out soon with a number of speed improvements and bug fixes.


Reply to this email directly or view it on GitHub
#195 (comment)
.

Lewis

@lewismc
Copy link
Contributor Author

lewismc commented Oct 1, 2015

New PR here
Homebrew/legacy-homebrew#44490
A number of issues were logged and discovered whilst building the brew formula so hopefully we can iron some of them out.

@lewismc
Copy link
Contributor Author

lewismc commented Oct 1, 2015

Hi @mjpost can you please stage https://github.com/joshua-decoder/indian-parallel-corpora/tarball/master as a static indian-languages.tgz artifact somewhere?
When I download it from Github within the homebrew formula it unpacks to a different directory every time. The brew recipe requires static files with a consistent sha256. Right now this is impossible for me to do unless the artifact is staged. Can you name it indian-languages-6.0.4.tgz ?

@mjpost
Copy link
Member

mjpost commented Oct 2, 2015

I just created an official release. You can download using this link. I will update the quick start instructions.

@lewismc
Copy link
Contributor Author

lewismc commented Oct 2, 2015

Grand. Nearly ready for iteration 4. Will be posting in around 10 minutes for the PR. Seem to have everything working within the brew install now. N.B. I am working off of Git HEAD as follows

brew install -ivd joshua-v --HEAD

This enters interactive mode, debug mode and verbose mode and checks out Git HEAD then build and installs it locally.

@lewismc
Copy link
Contributor Author

lewismc commented Oct 5, 2015

PR updated on and will hopefully be merged this time.
Homebrew/legacy-homebrew#44490
Fingers crossed.

@mjpost
Copy link
Member

mjpost commented Oct 5, 2015

Hi Lewis — Sorry, just buried under other stuff. I hope to get to this today.

@lewismc
Copy link
Contributor Author

lewismc commented Oct 5, 2015

No problems I'll update once the PR has been merged over at Homebrew.
Thanks

On Monday, October 5, 2015, Matt Post [email protected] wrote:

Hi Lewis — Sorry, just buried under other stuff. I hope to get to this
today.

  • matt


Reply to this email directly or view it on GitHub
#195 (comment)
.

Lewis

@lewismc
Copy link
Contributor Author

lewismc commented Dec 29, 2015

OK this issue has been addressed and Joshua is available in Homebrew :)
You can check out the options as follows

lmcgibbn@LMC-032857 /usr/local(joshua) $ brew info joshua
joshua: stable 6.0.5, HEAD
Statistical machine translation decoder.
http://joshua-decoder.org/
/usr/local/Cellar/joshua/6.0.5 (1855 files, 172M) *
  Built from source
From: https://github.com/Homebrew/homebrew/blob/master/Library/Formula/joshua.rb
==> Dependencies
Build: ant ✔, boost ✔, md5sha1sum ✔
==> Options
--with-ar-en-phrase-pack
    Build with Arabic–English phrase-based model [2.4 GB].
--with-es-en-phrase-pack
    Build with Spanish–English phrase-based model [1.9 GB].
--HEAD
    Install HEAD version

@lewismc lewismc closed this as completed Dec 29, 2015
@lewismc
Copy link
Contributor Author

lewismc commented Dec 29, 2015

@mjpost can we update the Homebrew formula within the release procedure? It would be nice to have it up-to-date.

@mjpost
Copy link
Member

mjpost commented Jan 4, 2016

Yes, of course. What needs to be done?

@lewismc
Copy link
Contributor Author

lewismc commented Jan 4, 2016

So if you look at the Joshua recipe all you need to do is

  1. update the link to the Joshua release artifact
  2. update the SHA256 signature for the release artifact

... that's it. Super simple :)

@mjpost
Copy link
Member

mjpost commented Jan 4, 2016

Update it to what? It looks up-to-date to me.

@lewismc
Copy link
Contributor Author

lewismc commented Jan 5, 2016

Sorry, I meant that when a new release is made then both of the above can be updated to the new release artifact. Is there a release process somewhere that I can see? If not then maybe now is a good time to make one and I can add the Homebrew portion. wdyt?
Nothing has to be done right now, this is for the future.

@mjpost
Copy link
Member

mjpost commented Jan 8, 2016

There is no release document, but there should be. I've added a TODO item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants