Formular for Joshua Decoder v6.0.4 #44490
Conversation
|
@lewismc do we know the issues here? |
|
Yep... there are some bugs in Joshua which I've fixed. I think I may need to update this PR to accommodate those. |
|
Atually @chrismattmann on second thoughts I don't know. |
|
@bfontaine I am unsure as to what has gone wrong here? Can you possibly provide insight into how I can get tests passing here please? Thanks in advance. |
|
|
||
| resource "es-en-phrase-pack" do | ||
| url "http://cs.jhu.edu/~post/language-packs/language-pack-es-en-phrase-2015-03-06.tgz" | ||
| sha256 "213E05BBDCFBFA05B31E263C31F10A0315695FEE26C2F37B0A78FB918BAD9B5D" |
There was a problem hiding this comment.
Please use a lowercased sha256 here and for the resource below.
|
@lewismc See http://bot.brew.sh/job/Homebrew%20Pull%20Requests/34025/version=yosemite/testReport/junit/brew-test-bot/yosemite/fetch_joshua_v/ The sha256 checksum seems wrong. You can check it with: |
| end | ||
|
|
||
| test do | ||
| system "mkdir -p ~/models/bn-en" |
There was a problem hiding this comment.
The test is executed in a temporary directory; you don’t need to create a new one.
| desc "Joshua is an open-source statistical machine translation decoder." | ||
| homepage "http://joshua-decoder.org/" | ||
| url "http://cs.jhu.edu/~post/files/joshua-v6.0.4.tgz" | ||
| sha256 "0cf6674dc73f30e49a22179e90182492f8e8eea46710b505edb9acfb4d953d9a" |
There was a problem hiding this comment.
How did you get this checksum?
There was a problem hiding this comment.
As follow
http://apache.org/dev/release-signing.html#sha-checksum
$ gpg --print-md SHA256 [fileName] > [fileName].sha
There was a problem hiding this comment.
I get a different checksum:
$ shasum -a 256 < joshua-v6.0.4.tgz
0e3b08c80303106599aa404bbba5c801cc5542779bef828d35ff80288190c273 -
$ gpg --print-md SHA256 joshua-v6.0.4.tgz
joshua-v6.0.4.tgz: 0E3B08C8 03031065 99AA404B BBA5C801 CC554277 9BEF828D
35FF8028 8190C273
There was a problem hiding this comment.
This was the original checksum I calculated and was asked to lowercase everything. Which format o you want? I can update the PR to accomodate if you prefer.
There was a problem hiding this comment.
We use lowercased checksums; what I mean is that the checksum you wrote is different from the one I got:
0cf6674dc73f30e49a22179e90182492f8e8eea46710b505edb9acfb4d953d9a v.s.
0e3b08c80303106599aa404bbba5c801cc5542779bef828d35ff80288190c273
This is also the one the bot gets:
==> Downloading http://cs.jhu.edu/~post/files/joshua-v6.0.4.tgz
Downloaded to: /Library/Caches/Homebrew/joshua-v-6.0.4.tgz
SHA1: d240cc2b09b01feba03f0ac5d46b4c8d81ce01b1
SHA256: 0e3b08c80303106599aa404bbba5c801cc5542779bef828d35ff80288190c273
Are you behind a proxy that might modify HTTP responses?
There was a problem hiding this comment.
@bfontaine possibly. I've updated it now and double checked all of the others. I checked all SHA256 with
shasum -a 256 [file name]
Thanks for review.
|
@bfontaine I updated the PR based on feedback from |
| class JoshuaV < Formula | ||
| desc "Joshua is an open-source statistical machine translation decoder." | ||
| homepage "http://joshua-decoder.org/" | ||
| url "http://cs.jhu.edu/~post/files/joshua-v6.0.4.tgz" |
There was a problem hiding this comment.
You can use https:// for this url.
|
Closing this PR as it has been superseded by #45746 |
This is a clean pull request for including a Formula for Joshua Decoder. It is updated from #44384
Thank you