Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] Update ember-auto-import to v2 #43

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

simonihmig
Copy link
Contributor

This is a breaking change, as the consuming app needs to upgrade as well. See https://github.com/ef4/ember-auto-import/blob/main/docs/upgrade-guide-2.0.md.

Relates to #42 (comment)

@simonihmig
Copy link
Contributor Author

So this is failing with Ember 4.0 due to some incompatibility with liquid-fire, which is a dependency of ember-cli-addon-docs.

This setup of having the dummy app serve both as the test-app as well as the docs-app is quite unfortunate IMO. Was already bitten by this myself more than once. There is no reason to run the docs-app with all ember scenarios, as it has to be built only with its own Ember version. But as docs and tests are in one app, we cannot separate those concerns...

It could be solved by migrating to a monorepo setup, with the addon and two distinct apps. But that's not what I would be able to contribute. But what is quite urgent for me is that we fix #42, as it seems the latest Ember beta and canary releases have removed the deprecated 3.13 capabilities (glimmerjs/glimmer-vm#1329), which makes the modifier fail totally (Error: Invalid modifier manager compatibility specified).

@josemarluedke any suggestion?

@josemarluedke
Copy link
Owner

@simonihmig Thanks for working on this. Migrating to a monorepo is what makes the most sense to me as well. I will merge this change and we will work on that next.

@josemarluedke josemarluedke merged commit 9d1d4f6 into josemarluedke:main Nov 18, 2021
@simonihmig simonihmig deleted the eai2 branch November 18, 2021 16:43
@simonihmig
Copy link
Contributor Author

@josemarluedke thanks for merging! Even though CI is failing now for known reasons, would you mind cutting a release?

I tested the latest commit in this PR for ember-bootstrap, and CI is passing, including for all Ember 4.x release channels: ember-bootstrap/ember-bootstrap#1705

@josemarluedke
Copy link
Owner

@simonihmig Published v0.8.0 with these changes.

@simonihmig
Copy link
Contributor Author

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants