Fix capabilities semver range for Ember 4 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have seen deprecation warning when running Ember 4 with this addon, as the existing semver range was not correctly accounting for the higher major version (my fault in a previous PR).
|
So tests for Ember 4 are failing unrelated to these changes here. The dummy app needs ember-auto-import v2, which can be solved by bumping the addon's dependency to v2 (a breaking change, but worthwhile!) or adding eai v2 and webpack only in the ember-try scenarios. See the discussion in emberjs/ember.js#19761. I would opt for the first option, but it's your call @josemarluedke! 🙂 |
|
@simonihmig I would go with option one as well. We could also migrate to a V2 addon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have seen deprecation warning when running Ember 4 with this addon, as the existing semver range was not correctly accounting for the higher major version (my fault in a previous PR).